<p>Hi Eugene,</p>
<p>On Oct 27, 2012 7:18 AM, "Eugene Voronkov" <<a href="mailto:eugene.voronkov@gmail.com">eugene.voronkov@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Fri, Oct 26, 2012 at 5:38 AM, Sumeet pawnikar <<a href="mailto:sumeet4linux@gmail.com">sumeet4linux@gmail.com</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov <<a href="mailto:eugene.voronkov@gmail.com">eugene.voronkov@gmail.com</a>> wrote:<br>
>>><br>
>>> I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more information. At what point do code style patches stop being more trouble then they're worth to the maintainers? For example, running <a href="http://checkpatch.pl">checkpatch.pl</a> against all files is showing around 3 non-trivial style violations per file. Would a patch fixing 12 violations across 4 files be worth submitting? <br>
>>><br>
>>><br>
>>> 1. <a href="http://www.youtube.com/watch?v=LLBrBBImJt4">http://www.youtube.com/watch?v=LLBrBBImJt4</a><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> Kernelnewbies mailing list<br>
>>> <a href="mailto:Kernelnewbies@kernelnewbies.org">Kernelnewbies@kernelnewbies.org</a><br>
>>> <a href="http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies">http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies</a><br>
>>><br>
>> Suggestion would be, divide your single patch in separate individual patches with respect to functionality/violations fix. <br>
><br>
><br>
><br>
> So for example, one patch removes braces from if/else conditionals with single statement. Another patch fixes incorrect spacing. Correct?</p>
<p>Best to fix all checkpatch errors and warnings in the same file in the same patch. If you ate fixing two related files (two files in the same driver for example) then I would put them both in the same patch as well.</p>
<p>If the two files are unrelated, keep the patches separate.</p>
<p>Don't mix functional changes with cosmetic (checkpatch) fixups.</p>
<p>Regards,</p>
<p>Graeme</p>