<br><br><div class="gmail_quote">On Fri, Oct 26, 2012 at 5:38 AM, Sumeet pawnikar <span dir="ltr"><<a href="mailto:sumeet4linux@gmail.com" target="_blank">sumeet4linux@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div class="im">On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov <span dir="ltr"><<a href="mailto:eugene.voronkov@gmail.com" target="_blank">eugene.voronkov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style. I feel like this would be a good way for me to jump into the process but I need more information. At what point do code style patches stop being more trouble then they're worth to the maintainers? For example, running <a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> against all files is showing around 3 non-trivial style violations per file. Would a patch fixing 12 violations across 4 files be worth submitting? </div>
</blockquote></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br></div><div>1. <a href="http://www.youtube.com/watch?v=LLBrBBImJt4" target="_blank">http://www.youtube.com/watch?v=LLBrBBImJt4</a></div><div><br></div>
<br>_______________________________________________<br>
Kernelnewbies mailing list<br>
<a href="mailto:Kernelnewbies@kernelnewbies.org" target="_blank">Kernelnewbies@kernelnewbies.org</a><br>
<a href="http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies" target="_blank">http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies</a><br>
<br></blockquote></div>Suggestion would be, divide your single patch in separate individual patches with respect to functionality/violations fix. </blockquote></div><br><div><br></div><div>So for example, one patch removes braces from if/else conditionals with single statement. Another patch fixes incorrect spacing. Correct?</div>