<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>By one thing per patch you mean that I can correct say for example all the 80 char per line warnings in a single file as a patch?</span></div><div><span><br></span></div><div><span>Kashyap Gada<br></span></div><div><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Greg KH <greg@kroah.com><br> <b><span style="font-weight: bold;">To:</span></b> Daniel Baluta <daniel.baluta@gmail.com> <br><b><span style="font-weight: bold;">Cc:</span></b> kashyap gada <kashyapgada@yahoo.com>; "kernelnewbies@kernelnewbies.org" <kernelnewbies@kernelnewbies.org> <br> <b><span
style="font-weight: bold;">Sent:</span></b> Sunday, 5 February 2012 10:51 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: How to create patch for checkpatch.pl cleanups<br> </font> </div> <br>On Sun, Feb 05, 2012 at 11:10:29PM +0200, Daniel Baluta wrote:<br>> On Sun, Feb 5, 2012 at 11:00 PM, kashyap gada <<a ymailto="mailto:kashyapgada@yahoo.com" href="mailto:kashyapgada@yahoo.com">kashyapgada@yahoo.com</a>> wrote:<br>> > Hello Linux Newbies, I'm one too. I was looking out for some clean up work<br>> > and I ran the checkpatch.pl script. I came across a file with some 400<br>> > errors and 200 warnings. Now there were bunch of 80 char per line warning ,<br>> > braces and related things. I don't want to be sending patches for each and<br>> > every error or warning I fix as it becomes tedious and If i send lots of<br>> > correction patches in one go the kernel maintainers wont accept it. I
want<br>> > to know Can we correct all similar errors or warnings in one patch? or<br>> > series of patches?<br>> <br>> Regarding 80 chars per line issues, people are discussing right now<br>> on increasing the limit to 100. See [1].<br>> <br>> For the other issues, just send a patch with all the changes. It should<br>> be fine since you are modifying one single file.<br><br>No, please break it up into "one thing per patch" to make it easy to<br>review, otherwise it will be ignored and/or rejected.<br><br>Also realize that a lot of subsystem maintainers do not like these types<br>of patches, outside of the drivers/staging/ area, so you might want to<br>ask the subsystem developers if they will take this type of work before<br>you do it.<br><br>greg k-h<br><br><br> </div> </div> </div></body></html>