<br><br><div class="gmail_quote">On Mon, Jan 30, 2012 at 10:51 PM, amit mehta <span dir="ltr"><<a href="mailto:gmate.amit@gmail.com">gmate.amit@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
kernel janitors group seem like a good place to start learning linux kernel and<br>
after reading some of the information available on kernel newbies website, i<br>
tried to generate a dummy patch and need your help for moving in correct<br>
direction of learning and contributing to linux kernel. So these are<br>
the steps that i've followed to generate this dummy patch.<br>
<br>
1: Download the latest linux kernel sources using git<br>
# mkdir linux-next<br>
# cd linux-next<br>
# git clone git://<a href="http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
linux-2.6" target="_blank">git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git<br>
linux-2.6</a><br>
<br>
2: Do some modifications.<br>
# pwd<br>
/root/linux-next/linux-2.6<br>
<br>
# git diff<br>
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c<br>
index 6e412a6..9858701 100644<br>
--- a/net/ipv4/ipconfig.c<br>
+++ b/net/ipv4/ipconfig.c<br>
@@ -441,7 +441,7 @@ static int __init ic_defaults(void)<br>
&ic_myaddr);<br>
return -1;<br>
}<br>
- printk("IP-Config: Guessing netmask %pI4\n", &ic_netmask);<br>
+ printk(KERN_INFO "IP-Config: Guessing netmask %pI4\n",<br>
&ic_netmask);<br>
}<br>
<br>
return 0;<br>
<br>
3: Generate a patch<br>
# pwd<br>
/root/linux-next/linux-2.6<br>
# mkdir ../patches<br>
# git diff >../patches/ipconfigPatch.txt<br>
<br></blockquote><div> </div><div>Strictly speaking, a complete patch has many more things, like</div><div>a commit message, Signed-off-by line etc. Of course, if you are just</div><div>playing around with patches just for fun, you need not worry about this.</div>
<div>But if you want to contribute to the linux kernel, you would need to take</div><div>care of all that.</div><div><br></div><div>So, for that, instead of git diff, use:</div><div><br></div><div># git commit -a</div><div>
Type an appropriate commit message and add your Signed-off-by.</div><div>(Your git configurations can help you automate stuff like Signed-off-by).</div><div><br></div><div># git format-patch -1 HEAD</div><div>This will generate the patch for you. You can mail this using git send-email</div>
<div>or by copy pasting it in your email client.</div><div><br></div><div>You can refer to the video by Greg about submitting patches.</div><div><a href="http://www.youtube.com/watch?v=LLBrBBImJt4">http://www.youtube.com/watch?v=LLBrBBImJt4</a></div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
4: Test your patch<br>
4a: Clear the local changes from the tree<br>
# git checkout -f<br>
<br>
4b: Apply the patch<br>
# git apply ../patches/ipconfigPatch.txt<br>
<br>
<br>
The above step(4b) did not returned any git error so it seems to me that the<br>
steps to generate this patch was correct.<br>
<br>
5: Check your mailer<br>
5a: I just copied the contents of ../patches/ipconfigPatch.txt and pasted in<br>
the compose area and sent that mail to myself. After receiving this mail i<br>
copied and pasted the mail contents in a file under<br>
/root/linux-next/patches/dummyPatch.txt and tried to apply this patch<br>
using git but it gave me an error as below:<br>
# git apply ../patches/dummy.txt<br>
fatal: corrupt patch at line 11<br>
<br></blockquote><div> </div><div>Ah, I think your email client corrupted it! (white-space damage perhaps)</div><div>Check out Documentation/email-clients.txt for more info on how to make your</div><div>email clients behave :-)</div>
<div> <br>Regards,</div><div>Srivatsa S. Bhat</div></div>