Kernel upstream compile error at drivers/staging/media

[Lukas Bulwahn]

On Wed, Sep 8, 2021 at 6:00 PM Lafan Mining <lkfan at protonmail.com> wrote:
>
> On Wednesday, September 8th, 2021 at 12:50, Greg KH <greg at kroah.com> wrote:
>
> > Please update your kernel version, this should already be fixed.
>
> It's not. There have been sent several patches already to fix this issue. Here are 2 of them:
>
> 1. https://lkml.org/lkml/2021/9/5/146
> 2. https://lore.kernel.org/lkml/20210802143820.1150099-1-arnd@kernel.org/
>
> And no one of them has been applied yet. Here is the log of the file input_system.c:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
>

Good own investigation so far.

The patch you point out is already applied to a maintainer's (Mauro's)
integration tree, and hence in linux-next:

commit 05344a1d2ea7bad3492c34299c37407bfcfed355
Author: Arnd Bergmann <arnd at arndb.de>
Date:   Mon Aug 2 16:38:14 2021 +0200

    media: atomisp: restore missing 'return' statement

    The input_system_configure_channel_sensor() function lost its final
    return code in a previous patch:

    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:
In function 'input_system_configure_channel_sensor':
    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1:
error: control reaches end of non-void function [-Werror=return-type]

    Restore what was there originally.

    Link: https://lore.kernel.org/linux-media/20210802143820.1150099-1-arnd@kernel.org
    Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
    Signed-off-by: Arnd Bergmann <arnd at arndb.de>
    Acked-by: Sakari Ailus <sakari.ailus at linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei at kernel.org>


So, it is just a matter of hours until Linus takes the pull request
from Mauro, v5.15-rc1 is out and the issue is resolved. If you ping
Greg with this patch being good for stable, he will pick it and
probably apply that for the v5.14 stable tree as well.

So be a bit patient, or change your config... Do you really need this
driver? Is it really important to you and your business? Then,
consider that it is currently under drivers/staging/ and might just
disappear from one day to another because nobody is aware of critical
users (that is why it is in staging in the first place).

I hope this helps,

Lukas