[PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

Leon Romanovsky leon at kernel.org
Thu Apr 29 03:05:13 EDT 2021

On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Klētnieks wrote:
> On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said:
> > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> > > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> > > Maybe those should be changed?
> >
> > Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.
> Will that actually build correctly if it's an embedded system or something build with
> CONFIG_PROC_FS=n?  I'd expect that to die a horrid death while linking vmlinx due
> to stuff inside that #ifdef calling symbols only present with PROC_FS=m/y.

We are talking about pci_proc_detach_device() and pci_proc_detach_bus() here.
They will build perfectly without CONFIG_PROC_FS.


More information about the Kernelnewbies mailing list