[Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)
joe at perches.com
Sun Sep 27 13:45:45 EDT 2020
On Sun, 2020-09-27 at 19:08 +0200, Julia Lawall wrote:
> I end up with 208 patches. I'm not sure that sending them all at once
> would be a good idea...
Last I looked the diffstat for comma -> semicolon was:
234 files changed, 509 insertions(+), 509 deletions(-)
So it would be nearly 1 patch per individual file,
Greg KH does send hundreds of patches for -stable at a time.
So, maybe or maybe not send them all at once.
Maybe send it in batches of 25 or so.
There's no single right way to do this.
Maybe put up a git tree somewhere and let the
kernel-robot test compilation.
(A nicety might be for the kernel-robot to have some
option to test pre and post compilation object code
differences with an optional report)
When I automated 491 patches for /* fallthrough */ to
fallthrough;, the robot caught a couple problems which
I only posted the first ~30 patches though with
about 50% acceptance. Gustavo Silva picked up the
effort and did a great job. Eventually, a single
treewide patch was posted and accepted by Linus for
this though after dozens of individual patches went
through various maintainer trees:
$ git log --shortstat -1 df561f6688fe
Author: Gustavo A. R. Silva <gustavoars at kernel.org>
Date: Sun Aug 23 17:36:59 2020 -0500
treewide: Use fallthrough pseudo-keyword
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough. Also, remove unnecessary
fall-through markings when it is the case.
Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>
1148 files changed, 2667 insertions(+), 2737 deletions(-)
More information about the Kernelnewbies