Please give advise about my first patch attempt

Pawan Gupta writetopawan at gmail.com
Thu Aug 27 14:32:19 EDT 2020


On Thu, Aug 27, 2020 at 10:49:51AM +0200, Thomas Schmitt wrote:
> Hi,
> 
> i am preparing my first patch.
> May i ask for review and advise how to make it acceptable ?

If you are not running it already you can catch common mistakes by
running checkpatch script from the kernel source top directory like:

  $ ./scripts/checkpatch.pl --strict --codespell -g <commit-id>

Also would suggest to build kernel with warnings treated as errors:

  $ make CFLAGS_KERNEL+=-Werror ...

Thanks,
Pawan



More information about the Kernelnewbies mailing list