Please give advise about my first patch attempt

Greg KH greg at kroah.com
Thu Aug 27 09:19:59 EDT 2020


On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote:
> Hi Thomas,
> 
> Noob here.
> 
> On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt <scdbackup at gmx.net> wrote:
> >
> > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched
> > sr_drive_status() away from indirectly using sr_do_ioctl() for sending
> > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop for
> > the drive's intermediate sense reply:
> 
> In a recent Patch of mine, Greg nicely pointed out that commits should
> have a standard format across mailing lists: sha ("Commit Message").
> 
> See: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2235132.html

That is also documented in the ever-growing submitting patches document
somewhere...

thanks,

greg k-h



More information about the Kernelnewbies mailing list