[PATCH v2] staging: pi433: add mutex fixing concurrency issues.
Dan Carpenter
dan.carpenter at oracle.com
Tue Jun 12 08:11:07 EDT 2018
On Sat, Jun 09, 2018 at 11:48:42AM -0400, Hugo Lefeuvre wrote:
> case PI433_IOC_WR_TX_CFG:
> if (copy_from_user(&instance->tx_cfg, argp,
> sizeof(struct pi433_tx_cfg)))
> return -EFAULT;
> break;
Btw, it looks so wrong to me that we copy partial data to
&instance->tx_cfg... I'd really prefer copying it to a tmp buffer and
then verifying it's corrent then memcpy()ing it to &instance->tx_cfg.
regards,
dan carpenter
More information about the Kernelnewbies
mailing list