[PATCH] staging: pi433: add rw semaphore fixing concurrency issues
    Hugo Lefeuvre 
    hle at owl.eu.com
       
    Sat Jun  2 14:08:08 EDT 2018
    
    
  
Hi,
> Unless you can measure the performance difference, do not use a rw
> semaphore, just use a normal mutex please.  Odds are it will be faster
> in the end and take up less space.
> 
> So please test, or if you can't test, just use a mutex.
I don't have the device yet, so I won't be able to test. I have opted for the
mutex instead.
I have just sent an updated version fixing another issue in my code: The
mutex can't be included in pi433_instance because we have to lock it
before dereferencing our pi433_instance pointer. The best solution I
could think of was to create a wrapper struct pi433_data which would contain
pointers to the pi433_instance and its mutex. I couldn't find any
similar situation in the kernel, so I'm not sure it's the right way to
go though.
Thanks !
Regards,
 Hugo
-- 
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20180602/db6d9bc4/attachment.sig>
    
    
More information about the Kernelnewbies
mailing list