[PATCH] staging: pi433: add rw semaphore fixing concurrency issues

valdis.kletnieks at vt.edu valdis.kletnieks at vt.edu
Fri Jun 1 09:32:22 EDT 2018


On Fri, 01 Jun 2018 08:50:37 -0400, Hugo Lefeuvre said:

> @@ -805,9 +809,11 @@ pi433_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)
>  	if (bytes_received > 0) {
>  		retval = copy_to_user(buf, device->rx_buffer, bytes_received);
>  		if (retval)
> +			up_read(&instance->instance_sem);
>  			return -EFAULT;
>  	}
>
> +	up_read(&instance->instance_sem);
>  	return bytes_received;
>  }

This doesn't do what you think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 486 bytes
Desc: not available
URL: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20180601/136744fb/attachment.sig>


More information about the Kernelnewbies mailing list