sizeof
Tobin C. Harding
me at tobin.cc
Tue Mar 7 18:20:37 EST 2017
Question relating to the validity/usefulness of patching calls to sizeof.
>From Documentation/process/coding-style.rst
The preferred form for passing a size of a struct is the following:
.. code-block:: c
p = kmalloc(sizeof(*p), ...);
The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not.Is the distinction between
Question:
Is a the following a valid/useful patch or just code churn
diff--
- sizeof(struct foo)
+ sizeof(*fp)
---
More information about the Kernelnewbies
mailing list