query regarding emxx_udc

Greg KH greg at kroah.com
Wed Feb 8 02:26:15 EST 2017


On Wed, Feb 08, 2017 at 12:46:58PM +0530, Deeksha varshney wrote:
> In the file file drivers/staging /emxx_udc/emxx_udc.c every EPn_ type variable
> should be modified in seperate patches ?
> like EPn_BUF_TYPE should be modified as  EPN_BUF_TYPE in one patch
> and EPn_MPKT as EPN_MPKT in another patch.?

Step back and think about what you are changing here.  Why is the
current naming scheme not correct?  It properly describes what the
define is, and what it is for.  I would strongly recommend just leaving
it as-is, there is nothing wrong with it.

Remember, checkpatch.pl is a _hint_, you always have to use your brain
when reading the output of it.

hope this helps,

greg k-h



More information about the Kernelnewbies mailing list