should "get_user_pages()" really be phased out?

Robert P. J. Day rpjday at crashcourse.ca
Mon Jan 4 14:01:14 EST 2016


  poking around mm/gup.c at "get_user_pages()" and related routines,
and noticed this:

 * get_user_pages should be phased out in favor of
 * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing
 * should use get_user_pages because it cannot pass
 * FAULT_FLAG_ALLOW_RETRY to handle_mm_fault.

so does that mean what it seems to mean ... that nothing outside of
memory management should call get_user_pages() directly? i can see
that some of those other routines are implemented in terms of
get_user_pages() -- does that mean that get_user_pages() should be
made static so that only those routines are allowed to call it, and
everyone else should invoke one of the other routines?

  just trying to understand the eventual desired fate of
get_user_pages().

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




More information about the Kernelnewbies mailing list