Question about "Creating first patch" guide

[慕冬亮]

I don't know whether my procedure to generate patch is right.Share it
with you and you can comment it ,feed back to me!

First, I change the document in the master branch, but don't commit to
master branch. Then I use "git diff" to generate the patch.
At last , I do a check with checkpatch.pl.
If there is no error, I will post it to the according subsystem.
If there are any wrong tips, point it out for me.

Thank you.
    - mdongliang

2015-09-24 5:02 GMT+08:00 Rob Groner <rgroner at rtd.com>:
>> -----Original Message-----
>> From: Greg KH [mailto:greg at kroah.com]
>> Sent: Wednesday, September 23, 2015 3:44 PM
>> To: Rob Groner <rgroner at RTD.com>
>> Cc: kernelnewbies at kernelnewbies.org
>> Subject: Re: Question about "Creating first patch" guide
>>
>> On Wed, Sep 23, 2015 at 07:22:08PM +0000, Rob Groner wrote:
>> > The OutreachyfirstpatchSetup has been very helpful in setting up my
>> > computer to develop a patch to submit to the kernel overlords.
>> >
>> >
>> >
>> > I’m at the point where I’ve changed the kernel code, ran and test it,
>> > and see just my changes with “git diff”.  What has me a little
>> > confused is that before I actually create the patch file (to submit to
>> > the appropriate mailing list), it says to actually commit the change.
>> > Perhaps I don’t understand how git handles commit (I primarily use
>> > svn), but it seems like actually committing the change is kind of
>> > presumptuous before even posting anything on the mailing list of those
>> that control the git repository.
>> >
>> >
>> >
>> > What part am I not understanding?
>>
>> You should create a branch and work on that, making a commit there, then it
>> is trivial to turn that into a patch, as the tutorial suggests.
>>
>> With git, everything can be local, svn requires you to push your changes to
>> the server, which is the big difference here.
>>
>> hope this helps,
>>
>> greg k-h
>
> And sorry for the top-posting.  I had no idea that was a thing until 5 minutes ago.  Mailing lists are a completely new thing to me (at age 44+).
>
> Rob
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies