staging: wlan-ng: p80211conv.h: warning I don't understand

Silvan Jegen me at sillymon.ch
Thu Nov 12 04:36:59 EST 2015


Am 2015-11-12 04:54, schrieb Greg KH:
> On Thu, Nov 12, 2015 at 02:33:07AM +0000, Gavin O'Leary wrote:
>> Hello all,
>> 
>> I am new to the realm of linux kernel development. I've been sending 
>> in small
>> patches to fix check-patch warnings. I was fixing up the file listed 
>> in the
>> subject when I came across this warning.
>> 
>> drivers/staging/wlan-ng/p80211conv.c:622: WARNING: Possible 
>> unnecessary 'out of
>> memory' message
>> 
>> Source Code:
>> 
>> if (rxmeta == NULL) {
>>                 netdev_err(wlandev->netdev,
>>                            "%s: Failed to allocate rxmeta.\n", 
>> wlandev->name);
>>                 result = 1;
>>                 goto exit;
>> }
>> 
>> What is this warning about? How do I go about fixing it?
> 
> A "meta" comment, if you don't understand the warning, why would you
> want to do anything about it?

I assume he/she wants to learn and help. Supporting him/her in that 
endeavor is the right thing to do.


Cheers,

Silvan



More information about the Kernelnewbies mailing list