Submitted a first patch and no reply

[Valdis.Kletnieks at vt.edu]

On Thu, 08 Jan 2015 12:00:07 -0800, shirish gajera said:

> WARNING: Single statement macros should not use a do {} while (0) loop
>
> I have added single statement in curly braces, because it was giving
> me "WARNING: macros should not use a trailing semicolon".
>
> Signed-off-by: Shirish Gajera <gajerashirish at gmail.com>
> ---
>  drivers/staging/skein/skein_block.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/skein/skein_block.c
> b/drivers/staging/skein/skein_block.c
> index 66261ab..5f46cd6 100644
> --- a/drivers/staging/skein/skein_block.c
> +++ b/drivers/staging/skein/skein_block.c
> @@ -82,10 +82,10 @@ do {
>                   \
>  } while (0)
>  #else
>  /* looping version */
> -#define R256(p0, p1, p2, p3, ROT, r_num) \

Why did you not fix the definition of R256 in the other half of
the "#if SKEIN_UNROLL_256 == 0" code?  Or the definitions for R512
and R1024?  You cleaned up one case, and left another 5 cases alone....

(This is part of why blindly fixing checkpatch complaints without actually
looking at the code and understanding isn't always a good thing)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20150108/c058b11b/attachment.bin