why is "const u32 (*tab)[256]" not kerneldoc-able?

Bjørn Mork bjorn at mork.no
Tue Feb 3 08:38:13 EST 2015


Bjørn Mork <bjorn at mork.no> writes:

> Maybe the attached simple patch is good enough?  Completely untested
> except for a single run against that file....

Ah, umh, no.  That "const u32 (*)[256] tab" does not look correct:


crc32_le_generic(9)                                   Kernel Hacker's Manual                                  crc32_le_generic(9)

NAME
       crc32_le_generic - Calculate bitwise little-endian Ethernet AUTODIN II CRC32/CRC32C

SYNOPSIS
       u32 __pure crc32_le_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*)[256] tab, u32 polynomial);

ARGUMENTS
       crc         seed  value  for computation.  ~0 for Ethernet, sometimes 0 for other uses, or the previous crc32/crc32c value
                   if computing incrementally.

       p           pointer to buffer over which CRC32/CRC32C is run

       len         length of buffer p

       tab         little-endian Ethernet table

       polynomial  CRC32/CRC32c LE polynomial



I guess a proper fix is needed.



Bjørn



More information about the Kernelnewbies mailing list