[PATCH] allow strictatime to be set as a global default

[Mandeep Sandhu]

You've removed the strictatime option altogether. So how does that
satisfy people who _do_ want it?

Is there some other option that will enable it? Just curious.

-mandeep


On Fri, Dec 18, 2015 at 6:42 AM, Raymond Jennings <shentino at gmail.com> wrote:
> I'm aware of a little tiff regarding strictatime in the past, and I
> think I came up with a patch that might help everyone get what they
> want.  I'm already using it myself.
>
> I've had some review on #kernelnewbies for technical issues, how does
> this look?
>
> ---
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 4b917eb..6ce72d8 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -4,17 +4,6 @@
>
>  menu "File systems"
>
> -config DEFAULT_STRICTATIME
> -       bool "Use strictatime by default"
> -       default n
> -       help
> -         Use strictatime as a default mount option.
> -
> -         Strictatime preserves ancient historic behavior of keeping the
> atime field always up to date.
> -         However, it was changed in 2007 to relatime to reduce I/O load on
> block devices.
> -
> -         If unsure, say N.
> -
>  # Use unaligned word dcache accesses
>  config DCACHE_WORD_ACCESS
>         bool
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 48e7c15..0570729 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2680,15 +2680,9 @@ long do_mount(const char *dev_name, const char
> __user *dir_name,
>         if (retval)
>                 goto dput_out;
>
> -#ifdef CONFIG_DEFAULT_STRICTATIME
> -       /* Default to strictatime unless overridden */
> -       if (flags & MS_RELATIME)
> -               mnt_flags |= MNT_RELATIME;
> -#else
> -       /* Default to relatime unless overridden */
> +       /* Default to relatime unless overriden */
>         if (!(flags & MS_NOATIME))
>                 mnt_flags |= MNT_RELATIME;
> -#endif
>
>         /* Separate the per-mountpoint flags */
>         if (flags & MS_NOSUID)
>
>
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies