[PATCH 1/1] staging: wilc1000: replace addresses variables type from u32 to size_t for x64 systems

Raphaël Beamonte raphael.beamonte at gmail.com
Mon Aug 17 13:33:21 EDT 2015


2015-08-17 13:12 GMT-04:00  <Valdis.Kletnieks at vt.edu>:
> If you're going to do this, do it *right* and chase down where all these
> variables are defined and nail them down to a size_t *there* so you can get rid
> of most of these casts - plus potentially find *other* places they're playing
> fast and loose with the types.

You're right. I tried first to use the struct that is used to declare
pstrWFIDrv, but
as it needed a lot of code refactoring I switched to find an easier
path, but that's
not as elegant and clean.

> Umm.. this isn't for a brain-dead card that has to have its addresses
> down in the the first 4G of memory, is it?  Or was the driver author
> stuck on a 32-bit kernel?

Actually, that's what I wondered also! With further researchs, I just ended
up finding those patches in the linux-wireless mailing list:
http://www.spinics.net/lists/linux-wireless/msg138655.html
http://www.spinics.net/lists/linux-wireless/msg138656.html

These patches are not integrated with Greg's staging tree yet it seems. That's
probably why I missed them at first... They however seem more clean than mine.



More information about the Kernelnewbies mailing list