Trial Patch

nick xerofoify at gmail.com
Tue Sep 9 21:21:18 EDT 2014



On 14-09-09 06:03 PM, Valdis.Kletnieks at vt.edu wrote:
> On Tue, 09 Sep 2014 17:16:19 -0400, nick said:
> 
>> I am sending this in again fixed and working.
> 
> Typos are still there, and zero explanation of how you verified
> "fixed and working", which given your track record of failing to
> even compile test your code is a *big* show-stopper.
> 
> If you don't care about your patch enough to even bother fixing
> the typos, why should anybody else care?
> 
>> I also looked at your complain about write_nic_byte and this seems to be
>> there if this succeeds.
> 
> OK.  This is C 101.  How does write_nic_byte() get called if we just did
> the 'return false' and left both the do/while loop and the entire
> function in your patch?
> 
Not going to execute, I wasn't sure if that statement needs to be executed.
Seems it needs to be for the driver to be activated. Thanks for helping
out with my sloppiness :) and being patience. If there are any more problems
let me known.
Nick 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Fix-NULL-check-for-allocating-the-skb-in-r81.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140909/b3c63bd9/attachment.bin 


More information about the Kernelnewbies mailing list