[PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

Jeff Kirsher jeffrey.t.kirsher at intel.com
Wed Oct 22 01:20:21 EDT 2014


On Wed, 2014-10-22 at 10:20 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> > On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause
> <xerofoify at gmail.com> wrote:
> > > Fix checkpatch error message with opening bracket of if statement,
> > > not being on the same line as a if statement in rtw_ap.c
> > >
> > > Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
> > > ---
> > >  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > I will say, it does appear you finally got a patch right.  Only
> issue
> i agree to that. Finally Nick has sent a patch which is not having any
> style error, applies properly , doesnot change the logic.
> > I have is that you corrected only one of the many instances of the
> > same problem in this file.
> > If you are going to correct one instance, might as well fix them
> all.
> don't you think if he tries to fix them all at one go, he will again
> mess up everything ?

Possibly...  trust me, I am not jumping on the pro-nick band wagon here.
After many months of failed attempts, I am not holding my breath.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141021/289f186a/attachment.bin 


More information about the Kernelnewbies mailing list