[PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

Jeff Kirsher jeffrey.t.kirsher at intel.com
Tue Oct 21 23:31:25 EDT 2014


On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify at gmail.com> wrote:
> Fix checkpatch error message with opening bracket of if statement,
> not being on the same line as a if statement in rtw_ap.c
>
> Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I will say, it does appear you finally got a patch right.  Only issue
I have is that you corrected only one of the many instances of the
same problem in this file.
If you are going to correct one instance, might as well fix them all.

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 6b4092f..927b2a6 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
>                 }
>         }
>
> -       if (rtw_ht_operation_update(padapter) > 0)
> -       {
> +       if (rtw_ht_operation_update(padapter) > 0) {
>                 update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
>                 update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
>         }
> --
> 1.9.1
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



-- 
Cheers,
Jeff



More information about the Kernelnewbies mailing list