What to do with branches after submitting patches?
Prabhakar Lad
prabhakar.csengg at gmail.com
Fri Oct 11 04:54:19 EDT 2013
Hi Matthias,
On Fri, Oct 11, 2013 at 3:53 AM, Matthias Beyer <mail at beyermatthias.de> wrote:
> Hi,
>
> I just got into kernel development and currently doing some patching
> of the usb divers for coding style adaptions and so on.
>
> My current workflow is:
>
> - get latest torvalds master
> - merge local master with fast forward to torvalds/master
> - create new branch, say "usb-core-foobar-cleanup"
> - patch the stuff, write commits
> - git format-patch master...usb-core-foobar-cleanup
> - git send-email ...
>
> So what to do with the branches now? I think I should keep them until
> the patches are merged, okay. And then? delete them? I mean, I'm still
> the author of the patches, and they will be included in history some
> time (as soon as the next release comes out they will be in
> torvalds/master).
>
Yeah looks ok but , what you can do is USB is subsystem it should
be maintained by some person, which he has his own repo somewhere
in kernel.org clone his repo and do what your changes what you meant
and send the patches via send-email. You need to maintain your branch
until your patches are accepted because there might be some review
comments so you got to fix them and repost the patches. You can also
create your own repo on github and push that branch until then.
> I just submitted my second patch series to the lkml, and now I have to
> remember which patch series was the result of which branch... if I
> submit one or two more patch series, I have to remember the relations
> between patch series and branches until they are merged, yeah?
>
Yes
> Or is there something wrong in my workflow?
>
> Is it possible to use a github repository and just send a "please pull
> from git at github.com...." message to the kernel mailinglist, or will I
> be beaten for this?
>
You cannot directly send a pull request until the patches are reviewed,
once the the driver maintainer and other folks in the ML are happy, the
maintainer will pull your patches and get it merged in mainline kernel.
Regards,
--Prabhakar Lad
More information about the Kernelnewbies
mailing list