[PATCH] net: ethernet: clean out braces / old code (found via checkpatch)

Scott Lovenberg scott.lovenberg at gmail.com
Wed Oct 3 09:12:11 EDT 2012


On Wed, Oct 3, 2012 at 5:13 AM, Matthew Walster <matthew at walster.org> wrote:
>
>
> On 2 October 2012 17:16, Scott Lovenberg <scott.lovenberg at gmail.com> wrote:
>>
>> Looks good to me.
>
>
> Maintainer didn't think so :(
>
> On 2 October 2012 19:46, David Miller <davem at davemloft.net> wrote:
>>
>> That comment and that unconditional if() are documentation.
>>
>> Don't be an automaton and blindly make changes based upon
>> checkpatch.pl output.
>
>
> Perhaps I'll just clean up some of drivers/staging while I learn the process
> before I dive in to "net" again.
>
> Matthew Walster

Sorry, man.  I'm not going to mix it up with Dave Miller, but really
if he wanted that to stay in there a comment suggesting so would have
been nice.

-- 
Peace and Blessings,
-Scott.



More information about the Kernelnewbies mailing list